feat: PoC of inter-realm spec #2958

ltzmaxwell · 2024-10-16T10:22:03Z

address: the inter realm spec part from #2743.

Please refer to the original doc, and #2743 (comment)

And please see the comments below for details of implementation .

Contributors' checklist...

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests

codecov · 2024-10-16T10:23:54Z

Codecov Report

Attention: Patch coverage is 77.55102% with 55 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
gnovm/pkg/gnolang/realm.go	69.93%	41 Missing and 5 partials ⚠️
gnovm/pkg/gnolang/ownership.go	95.45%	2 Missing and 1 partial ⚠️
gnovm/pkg/gnolang/store.go	0.00%	2 Missing and 1 partial ⚠️
gnovm/pkg/gnolang/uverse.go	40.00%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

jefft0 · 2024-10-17T07:19:10Z

(The "review team" label was added by mistake. This PR is opened by a core dev.)

ltzmaxwell · 2025-02-16T07:13:25Z

examples/gno.land/r/demo/boards/z_4_filetest.gno

@@ -341,7 +341,7 @@ func main() {
 //                 "Base": {
 //                     "@type": "/gno.RefValue",
 //                     "Escaped": true,
-//                     "ObjectID": "336074805fc853987abe6f7fe3ad97a6a6f3077a:2"
+//                     "ObjectID": "purePkg:336074805fc853987abe6f7fe3ad97a6a6f3077a:2"


for object from pure package, make objectID with a prefix "purePkg", so it's possible to distinct with object from realm. this does not change the current realm object persistence. but it looks ugly.

@thehowl any idea for this?

maybe r:xxx and p:xxx is good.

ltzmaxwell · 2025-02-17T04:23:17Z

gnovm/tests/files/zrealm_crossrealm17a.gno

+// PKGPATH: gno.land/r/crossrealm_test
+package crossrealm_test
+
+import (
+	crossrealm "gno.land/r/demo/tests/crossrealm"
+)
+
+type container struct {
+	name string
+	f    *fooer
+}
+
+func (container) Foo() { println("hello " + c.f.name) }
+
+type fooer struct{ name string }
+
+var c = &container{name: "local_container"}
+
+func main() {
+	ff := &fooer{name: "local_foo"}
+	c.f = ff
+	crossrealm.SetFooer(c)
+	crossrealm.CallFooerFoo()
+	print(".")
+}
+
+// Output:
+// hello local_foo
+// .
+


This test demonstrates how the scenario functions:

the local_container will be firstly attached by reference to the external realm, after the external realm finalization, the embedding &fooer will be attached to current realm.

ltzmaxwell · 2025-02-17T08:04:51Z

gnovm/tests/files/zrealm_crossrealm22a.gno

+// PKGPATH: gno.land/r/crossrealm_test
+package crossrealm_test
+
+import (
+	crossrealm "gno.land/r/demo/tests/crossrealm/func"
+)
+
+var b = 1
+
+type Local_S struct {
+	name string
+}
+
+func main() {
+	f := func() bool {
+		c := b
+		var ls Local_S
+		return true
+	}
+	crossrealm.SetCallback(f)
+	println("ok")
+}
+
+// Output:
+// ok
+
+// Realm:
+// switchrealm["gno.land/r/demo/tests/crossrealm/func"]
+// switchrealm["gno.land/r/crossrealm_test"]


please see this discussion about FuncValue association .
#2958 (comment)

thehowl

I've spent most of today looking through realm.go and ownership.go so I could understand how they worked; I made a commit adding a bunch of comments which I hope are useful to whoever tries to understand it next.

I made some preliminary comments; I'll need another pass to be critical and proactive about different approaches / solutions.

gnovm/pkg/gnolang/ownership.go

thehowl · 2025-02-17T21:53:17Z

gnovm/pkg/gnolang/ownership.go

+	// realm where object is from
+	originRealm PkgID


What if we used a *PackageValue here instead? Could it not avoid us having to put whether it's a pure package in the PkgID?

Also this is a bit weird, because "from" makes it sound like it's about where it's declared; while really it's the type's package where possible. Could you also update it?

I can also try to make a better comment on these if you prefer, but if you make a first pass I think it's better ;)

thehowl · 2025-02-17T21:53:32Z

gnovm/pkg/gnolang/ownership.go

+	// realm where object is from
+	originRealm PkgID
+
+	// if this object is attaching as a base of reference


Would appreciate a better comment here, not quite clear what this is for. Can you write an example?

gnovm/pkg/gnolang/realm.go

thehowl · 2025-02-17T22:14:04Z

gnovm/pkg/gnolang/realm.go

@@ -220,9 +264,127 @@ func (rlm *Realm) DidUpdate(po, xo, co Object) {
 	}
 }

+// checkCrossRealm2 checks cross realm recursively.
+func checkCrossRealm2(rlm *Realm, store Store, tv *TypedValue, isLastRef bool, seenObjs []Object) {


do we have tests checking for some kinds of circular references?

thehowl

Sorry, was meant to be just a "comment". Putting request changes for now.

gnovm/tests/files/zrealm_crossrealm37_map.gno

ltzmaxwell · 2025-02-18T15:39:24Z

gnovm/tests/files/zrealm_crossrealm28_array.gno

+// PKGPATH: gno.land/r/crossrealm_test
+package crossrealm_test
+
+import (
+	crossrealm "gno.land/r/demo/tests/crossrealm/array"
+)
+
+var root interface{}
+
+func main() {
+	root = crossrealm.GetArray5()
+	println(".")
+}
+
+// Output:
+// .
+


this works even the result of GetArray5() is already real. the value is copied to current realm, and it's not bound to external realm, because its Type is not a declared type bound to the external realm.

ltzmaxwell added 14 commits June 24, 2024 16:52

naive fix

2dcdfd5

Merge branch 'master' of https://github.com/gnolang/gno

3056bcd

Merge branch 'master' of github.com:gnolang/gno

e69dfc0

Merge branch 'master' of https://github.com/gnolang/gno

9d05216

fix untyped bool

fb2f408

revert un-intentional change

22f973f

test files

2926b3d

debug

c3e3bdd

debug

72b28d7

save

00a59e7

external type

71c6fed

save

07d9029

save

8fdc399

more test

a604cdc

ltzmaxwell requested review from jaekwon, moul, piux2, thehowl, mvertes and a team as code owners October 16, 2024 10:22

github-actions bot assigned ltzmaxwell Oct 16, 2024

github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Oct 16, 2024

jefft0 added review/triage-pending PRs opened by external contributors that are waiting for the 1st review and removed review/triage-pending PRs opened by external contributors that are waiting for the 1st review labels Oct 16, 2024

ltzmaxwell added the in focus label Oct 19, 2024

zivkovicmilos added this to the 🚀 Mainnet launch milestone Oct 28, 2024

ltzmaxwell added 3 commits February 16, 2025 13:32

fixup

5aeadd6

clean

3bdaab2

sync

9136a1d

ltzmaxwell commented Feb 16, 2025

View reviewed changes

more tests for pure

ec7b3fe

ltzmaxwell changed the title ~~WIP fix(gnovm): PoC of inter-realm spec~~ feat (gnovm): PoC of inter-realm spec Feb 16, 2025

ltzmaxwell marked this pull request as ready for review February 16, 2025 07:31

ltzmaxwell changed the title ~~feat (gnovm): PoC of inter-realm spec~~ feat: PoC of inter-realm spec Feb 16, 2025

ltzmaxwell requested a review from thehowl February 16, 2025 07:33

ltzmaxwell commented Feb 17, 2025

View reviewed changes

simplify

7e05374

ltzmaxwell commented Feb 17, 2025

View reviewed changes

ltzmaxwell mentioned this pull request Feb 17, 2025

setting a closure across realm boundaries marks an entire block as owned by the called realm #3693

Open

ltzmaxwell requested review from jaekwon and moul February 17, 2025 09:35

test for 3693

06895d3

Kouteki requested a review from mvertes February 17, 2025 10:43

thehowl approved these changes Feb 17, 2025

View reviewed changes

thehowl requested changes Feb 17, 2025

View reviewed changes

only by type

49eb014

ltzmaxwell force-pushed the dev/maxwell/cross-realm branch from 1a6f3b9 to 49eb014 Compare February 18, 2025 15:30

ltzmaxwell commented Feb 18, 2025

View reviewed changes

gnovm/tests/files/zrealm_crossrealm37_map.gno Show resolved Hide resolved

ltzmaxwell commented Feb 18, 2025

View reviewed changes

ltzmaxwell added 7 commits February 19, 2025 00:03

map test

8e33a38

fixup

c82abd1

fix owner ID

2bbe398

rename

419ec8f

refactor

56513bd

simplify

10ff84c

revert ownerID logic

bb084a5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: PoC of inter-realm spec #2958

feat: PoC of inter-realm spec #2958

ltzmaxwell commented Oct 16, 2024 •

edited

Loading

codecov bot commented Oct 16, 2024 •

edited

Loading

jefft0 commented Oct 17, 2024

ltzmaxwell Feb 16, 2025

ltzmaxwell Feb 17, 2025

ltzmaxwell Feb 17, 2025 •

edited

Loading

ltzmaxwell Feb 17, 2025

ltzmaxwell Feb 17, 2025

ltzmaxwell Feb 17, 2025

thehowl left a comment

thehowl Feb 17, 2025

thehowl Feb 17, 2025

thehowl Feb 17, 2025

thehowl Feb 17, 2025

thehowl left a comment

ltzmaxwell Feb 18, 2025

feat: PoC of inter-realm spec #2958

Are you sure you want to change the base?

feat: PoC of inter-realm spec #2958

Conversation

ltzmaxwell commented Oct 16, 2024 • edited Loading

codecov bot commented Oct 16, 2024 • edited Loading

Codecov Report

jefft0 commented Oct 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ltzmaxwell Feb 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thehowl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thehowl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ltzmaxwell commented Oct 16, 2024 •

edited

Loading

codecov bot commented Oct 16, 2024 •

edited

Loading

ltzmaxwell Feb 17, 2025 •

edited

Loading